Taragolis commented on code in PR #28149: URL: https://github.com/apache/airflow/pull/28149#discussion_r1040899742
########## tests/providers/amazon/aws/operators/test_s3_file_transform.py: ########## @@ -34,8 +33,8 @@ from airflow.providers.amazon.aws.operators.s3 import S3FileTransformOperator -class TestS3FileTransformOperator(unittest.TestCase): - def setUp(self): +class TestS3FileTransformOperator: + def setup_method(self): Review Comment: Just optional suggestion (and reminder) because we could do it later by separate PR, when actually refactor some tests. We manually create here temporary files and remove it in teardown_method, it could be replaced by new fixture which use `tmp_path_factory` builtin pytest fixture https://github.com/apache/airflow/pull/27970/files#r1034288640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
