potiuk commented on PR #28153:
URL: https://github.com/apache/airflow/pull/28153#issuecomment-1339713661

   > @potiuk Oh. The warnings plugin you added seems to clash with Pytest-s 
`recwarn` fixture :(
   > 
   > `pytest.warns` still works, so I guess this is just a FYI for us.
   
   @ashb - It's not the plugin, but the `--disable-warnings` flag that I added 
to get rid of the duplicated warning output. 
   Actually, I even added an entry about to "writing unit tests" chapter in 
TESTING.rst when I added the plugin:
   
   https://github.com/apache/airflow/blob/main/TESTING.rst#writing-unit-tests
   
   > Use  pytest.warn to capture warnings rather than recwarn fixture. We are 
aiming for 0-warning in our tests, so we run Pytest with --disable-warnings but 
instead we have pytest-capture-warnings plugin that overrides recwarn fixture 
behaviour.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to