ephraimbuddy commented on code in PR #28076:
URL: https://github.com/apache/airflow/pull/28076#discussion_r1040450956
##########
airflow/config_templates/config.yml:
##########
@@ -2377,7 +2377,7 @@
failed worker pods will not be deleted so users can investigate them.
This only prevents removal of worker pods where the worker itself
failed,
not when the task it ran failed.
- version_added: 1.10.11
+ version_added: 2.5.0
Review Comment:
`AIRFLOW__KUBERNETES__POD_TEMPLATE_FILE` was 1.10.11 while
`AIRFLOW__KUBERNETES_EXECUTOR__POD_TEMPLATE_FILE` started existing in 2.5.0.
Makes me wonder if we should have a new field on the config file,
`version_renamed` or something because, in some way, this was really added in
2.5.0 but practically works down to 1.10.11 with old section where it was
originally added in the old section.
cc @ashb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
