Taragolis commented on code in PR #28279: URL: https://github.com/apache/airflow/pull/28279#discussion_r1047687069
########## tests/providers/amazon/aws/hooks/test_ecr.py: ########## @@ -0,0 +1,103 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +from unittest import mock + +import boto3 +import pytest +from moto import mock_ecr +from moto.core import DEFAULT_ACCOUNT_ID + +from airflow.providers.amazon.aws.hooks.ecr import EcrHook + + +@pytest.fixture +def patch_hook(monkeypatch): + """Patch hook object by dummy boto3 ECR client.""" + ecr_client = boto3.client("ecr") + monkeypatch.setattr(EcrHook, "conn", ecr_client) + yield + + +@mock_ecr +class TestEcrHook: + def test_service_type(self): + """Test expected boto3 client type.""" + assert EcrHook().client_type == "ecr" + + @pytest.mark.parametrize( + "accounts_ids", + [ + pytest.param("", id="empty-string"), + pytest.param(None, id="none"), + pytest.param([], id="empty-list"), + ], + ) Review Comment: And predictable cli command for run test for single parameter. It's useful during debagging when you change something and just one parameter stop working ```console ❯ pytest path/to.py::TestClassName:test_sample[empty-list] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
