o-nikolas commented on code in PR #28161:
URL: https://github.com/apache/airflow/pull/28161#discussion_r1049219335
##########
airflow/executors/base_executor.py:
##########
@@ -304,6 +304,9 @@ def execute_async(
"""
raise NotImplementedError()
+ def get_task_log(self, ti: TaskInstance, log: str = "") -> None | str |
tuple[str, dict[str, bool]]:
Review Comment:
Just noticed that this is missing a doc string. Do you mind adding one that
explains what this method does and that expectation is child classes implement
it (if desired) and also documenting the params/return values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
