Soonmok commented on code in PR #28398:
URL: https://github.com/apache/airflow/pull/28398#discussion_r1051279698
##########
airflow/api/common/trigger_dag.py:
##########
@@ -51,7 +51,11 @@ def _trigger_dag(
if dag is None or dag_id not in dag_bag.dags:
raise DagNotFound(f"Dag id {dag_id} not found")
- execution_date = execution_date if execution_date else timezone.utcnow()
+ if execution_date is None:
+ if conf and "logical_date" in conf:
+ execution_date = conf["logical_date"]
Review Comment:
In this
[tutorial](https://airflow.apache.org/docs/apache-airflow/1.10.1/tutorial.html),
default_args doesn't provide logical_date, but the issuer was assigning
`execution_date` to default_args.
I think we should check validation of using default_args.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
