vincbeck commented on PR #28282: URL: https://github.com/apache/airflow/pull/28282#issuecomment-1358271382
I agree with @eladkal. It feels to me you are modifying the operator `EmrAddStepsOperator` to handle a very niche use case. You want to cancel some EMR steps while adding some through `EmrAddStepsOperator` if they have the same name. I dont think it should be handled on the operator side but more a separate task in your DAG, or as a separate DAG. This is just my opinion and dont want to discourage you to contribute to Airflow. Overall I am not saying your code or even your idea is bad, I only think this is too specific (again, to me) to be handled on the operator. If all users would handle their business requirements in the operators, it would be a big mess :D Happy to hear others feedback but to me this not generic enough to be handled by the operator. On the other side I am not a big user of EMR, so if others think this is a good feature they'd like to have in `EmrAddStepsOperator`, happy to move forward with this :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
