dstandish commented on code in PR #27758:
URL: https://github.com/apache/airflow/pull/27758#discussion_r1055210093
##########
airflow/utils/log/logging_mixin.py:
##########
@@ -210,7 +210,11 @@ def set_context(logger, value):
if hasattr(handler, "set_context"):
from airflow.utils.log.file_task_handler import FileTaskHandler
- flag = cast(FileTaskHandler, handler).set_context(value)
+ if is_trigger and getattr(handler, "supports_triggerer", None):
+ flag = cast(FileTaskHandler, handler).set_context(value,
is_trigger=is_trigger)
+ logger.propagate = False
Review Comment:
yup, it was a remnant from the heavier-handed approach, where we were
setting context on logging mixin in triggerer job... but now we delegate the
context setting to the triggerwrapperhandler which sets it on the handler
instance directly, and propagation is irrelevant because it's on root logger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
