uranusjr commented on code in PR #28502:
URL: https://github.com/apache/airflow/pull/28502#discussion_r1063128910
##########
airflow/dag_processing/processor.py:
##########
@@ -365,8 +365,10 @@ def __init__(self, dag_ids: list[str] | None,
dag_directory: str, log: logging.L
self._dag_directory = dag_directory
self.dag_warnings: set[tuple[str, str]] = set()
+ @staticmethod
+ @internal_api_call
@provide_session
- def manage_slas(self, dag: DAG, session: Session = None) -> None:
+ def manage_slas(dag_folder, dag_id: str, log: logging.Logger, session:
Session = NEW_SESSION) -> None:
Review Comment:
I understand the technical aspects, but it would simply indicate either the
decorator should be improved to remove this restriction, or we need a new
mechanism (perhaps built upon `@internal_api_call` that can be used on an
instance method, not only static methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
