jedcunningham commented on code in PR #28844:
URL: https://github.com/apache/airflow/pull/28844#discussion_r1066432769


##########
airflow/executors/kubernetes_executor.py:
##########
@@ -52,6 +52,7 @@
 from airflow.utils.state import State
 
 ALL_NAMESPACES = "ALL_NAMESPACES"
+POD_DONE_KEY = "airflow_done"

Review Comment:
   Happy to adjust naming if there are better ideas.



##########
airflow/executors/kubernetes_executor.py:
##########
@@ -367,6 +368,18 @@ def delete_pod(self, pod_id: str, namespace: str) -> None:
             if e.status != 404:
                 raise
 
+    def patch_done_with_pod(self, *, pod_id: str, namespace: str):

Review Comment:
   Same here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to