csm10495 commented on code in PR #28808:
URL: https://github.com/apache/airflow/pull/28808#discussion_r1067308485
##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -272,6 +273,7 @@ def __init__(
pod_runtime_info_envs: list[k8s.V1EnvVar] | None = None,
termination_grace_period: int | None = None,
configmaps: list[str] | None = None,
+ base_container_name: str = "base",
Review Comment:
But what about for folks who don't want to change this instance wide and
instead want to set it on a single basis? To fully maintain support for
BASE_CONTAINER_NAME why not also have that and default this new param to None,
then if this is set it takes precedence, if not falls back to
BASE_CONTAINER_NAME?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
