Taragolis commented on code in PR #28925: URL: https://github.com/apache/airflow/pull/28925#discussion_r1071095629
########## airflow/providers/amazon/aws/links/glue.py: ########## @@ -0,0 +1,29 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from airflow.providers.amazon.aws.links.base_aws import BASE_AWS_CONSOLE_LINK, BaseAwsLink + + +class GlueJobLogsLink(BaseAwsLink): + """Helper class for constructing AWS Glue Job Logs Link""" + + name = "AWS Glue Job Logs" + key = "glue_job_logs" Review Comment: Yep, why not? We already add some similar for BatchOperator. I think for Glue it might required create a bit different link, e.g. Batch use link to a single LogStream, but Glue create multiple different log stream during execution so potentially we need to provide link to filter LogStream by specific Job ID -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
