vincbeck commented on code in PR #28502: URL: https://github.com/apache/airflow/pull/28502#discussion_r1071436440
########## airflow/dag_processing/processor.py: ########## @@ -365,8 +365,10 @@ def __init__(self, dag_ids: list[str] | None, dag_directory: str, log: logging.L self._dag_directory = dag_directory self.dag_warnings: set[tuple[str, str]] = set() + @staticmethod + @internal_api_call @provide_session - def manage_slas(self, dag: DAG, session: Session = None) -> None: + def manage_slas(dag_folder, dag_id: str, log: logging.Logger, session: Session = NEW_SESSION) -> None: Review Comment: Do you mean like [this](https://github.com/apache/airflow/pull/28502/commits/14546b1c872104edb4fb7ab8e6bcedbbc2767fc1)? I could not find a way to remove the duplicate methods of `log` and `get_log` in `logging_mixin.py`. If you have a solution, I'd be very happy to use it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org