okayhooni commented on PR #29056:
URL: https://github.com/apache/airflow/pull/29056#issuecomment-1399158194

   @potiuk 
   (thanks for your kind review..!)
   I agree with you that exception catch logic on dagbag will be simplified, if 
using just `except Exception`. so, I reflected in the code.
   
   But, I think anothor Exception class(`AirflowClusterPolicyError`) is 
necessary, because it facilitates intuitive identification of the cause of the 
error, just from exception CLASS NAME, although we can find the error cause 
from Web UI stacktrace(based on import_error table row) without it.
   
   In my opionion, if new exception class(`AirflowClusterPolicyError`) is not 
needed, explicit `AirflowClusterPolicyViolation` exception class is also not 
necessary. Because, user can raise any exception class(like `ValueError`, 
`FileNotFoundError`, or any custom exception) to suit the situation of the 
error.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to