sudeepgupta90 commented on code in PR #29078: URL: https://github.com/apache/airflow/pull/29078#discussion_r1083432364
########## docs/helm-chart/index.rst: ########## @@ -140,3 +140,22 @@ will not start as the migrations will not be run: This is so these CI/CD services can perform updates without issues and preserve the immutability of Kubernetes Job manifests. This also applies if you install the chart using ``--wait`` in your ``helm install`` command. + +.. note:: + While deploying this Helm chart with Argo, you might encounter issues with database migrations not running automatically on upgrade. + +To ensure database migrations with Argo CD, you will need to add: + +.. code-block::yaml + + migrateDatabaseJob: + jobAnnotations: + "argocd.argoproj.io/hook": Sync + +and, equivalent configurations in case of Flux CD + +.. note:: + This will ensure database migrations run when the Airflow Docker image is upgraded. This approach has a limitation in that the database migrations will run every time there is a ``Sync`` event in Argo. This is a trade-off for automation at the cost of some computational loss. Review Comment: Other changes in the helm chart values for deployment will also kick it off, apart from the image changes. Which is why I added this a note as this does have some limitations. I am happy to remove this as a note and convert it into normal text if you feel thats more appropriate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
