pierrejeambrun commented on code in PR #29098:
URL: https://github.com/apache/airflow/pull/29098#discussion_r1084331524


##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -477,8 +496,12 @@ To do this we need to
     twine upload -r pypitest dist/*
     ```
 
-- Verify that the test package looks good by downloading it and installing it 
into a virtual environment. The package download link is available at:
-https://test.pypi.org/project/apache-airflow/#files
+- Copy the package tar.gz download link available at 
https://test.pypi.org/project/apache-airflow/#files. Verify that the test 
package looks good by
+installing it with the constraint file into a new virtual environment. (adapt 
the constraint file python version to your virtual env setup)
+
+    ```shell script
+    pip install 
https://test-files.pythonhosted.org/packages/98/2c/82009f7760f341cc4e12c44da657c906415130ca60cd201d05e9b38caa38/apache-airflow-2.2.1rc1.tar.gz
 --constraint 
https://raw.githubusercontent.com/apache/airflow/constraints-2.2.1rc1/constraints-3.8.txt

Review Comment:
   Yes, I believe this is equivalent to this: (Tried it locally it works)
   ```
   pip install -i https://test.pypi.org/simple/ apache-airflow==2.5.1rc1
   ```
   
   I have an error when running your command. What constraint file will be used 
here ? Do we explicitly pass the constraint file so we verify that dependencies 
can be resolve with new constrainst ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to