dstandish commented on code in PR #29135:
URL: https://github.com/apache/airflow/pull/29135#discussion_r1085761659
##########
airflow/providers/google/common/hooks/base_google.py:
##########
@@ -491,7 +494,7 @@ def provide_gcp_credential_file_as_context(self) ->
Generator[str | None, None,
file in ``GOOGLE_APPLICATION_CREDENTIALS`` environment variable.
"""
key_path: str | None = self._get_field("key_path", None)
- keyfile_dict: str | None = self._get_field("keyfile_dict", None)
+ keyfile_dict: str | dict | None = self._get_field("keyfile_dict", None)
Review Comment:
Do we know the values will always be str though? Couldn't they be Int or
null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
