vandonr-amz commented on code in PR #28869:
URL: https://github.com/apache/airflow/pull/28869#discussion_r1086049943
##########
airflow/providers/amazon/aws/operators/appflow.py:
##########
@@ -93,6 +98,12 @@ def execute(self, context: Context) -> None:
self.connector_type = self._get_connector_type()
if self.flow_update:
self._update_flow()
+ # previous code had a wait between update and run without
explaining why.
+ # since I don't have a way to actually test this behavior,
+ # I'm reproducing it out of fear of breaking workflows.
+ # It might be unnecessary.
Review Comment:
checked it with the team, and it's true for on-demand flows (see
https://docs.aws.amazon.com/appflow/latest/userguide/flow-triggers.html for a
desc of the different types of flows)
I updated the comment accordingly.
Unfortunately, we don't have infra setup to be able to run the appflow
system test (because it depends on external sources), so it's a bit hard for me
to test it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
