dstandish commented on code in PR #29147:
URL: https://github.com/apache/airflow/pull/29147#discussion_r1087287016
##########
airflow/executors/kubernetes_executor.py:
##########
@@ -353,12 +353,12 @@ def run_next(self, next_job: KubernetesJobType) -> None:
self.run_pod_async(pod, **self.kube_config.kube_client_request_args)
self.log.debug("Kubernetes Job created!")
- def delete_pod(self, pod_id: str, namespace: str) -> None:
- """Deletes POD."""
+ def delete_pod(self, pod_name: str, namespace: str) -> None:
Review Comment:
> I'm interested to hear what others think though.
me too. i commented on the discussion thread. ideally i think only base
executor is public -- i.e. the executor interface -- and instances are not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
