vincbeck commented on code in PR #29183:
URL: https://github.com/apache/airflow/pull/29183#discussion_r1088278788
##########
tests/system/providers/amazon/aws/example_athena.py:
##########
@@ -117,6 +119,7 @@ def read_results_from_s3(bucket_name, query_execution_id):
query=query_read_table,
database=athena_database,
output_location=f"s3://{s3_bucket}/",
+ sleep_time=1,
Review Comment:
I dont think we should include this in the documentation. We might want to
set it outside of the doc tag. e.g. `read_table.sleep_time = 1`
##########
tests/system/providers/amazon/aws/example_dms.py:
##########
@@ -366,6 +367,7 @@ def delete_security_group(security_group_id: str,
security_group_name: str):
await_task_stop = DmsTaskCompletedSensor(
task_id="await_task_stop",
replication_task_arn=task_arn,
+ poke_interval=10,
Review Comment:
Same here. We should set it outside of the doc tag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
