dnskr commented on PR #29207:
URL: https://github.com/apache/airflow/pull/29207#issuecomment-1407403522
I recently upgraded Postgres instance, used by Airflow, from 11 to 15
version, so I would like to share my thoughts.
1. `pgbouncer.auth_type` shoud be `scram-sha-256` by default for Postgres
15, so current `md5` value is a bug and should be fixed in `values.yaml` for
Postgres 15 deployed by the subchart. Changing default value to `scram-sha-256`
fixes fresh installations with enabled `pgbouncer`, so, for example, the
following command deploys the helm chart correctly:
```
helm install test chart --set pgbouncer.enabled=true --set
pgbouncer.auth_type=scram-sha-256
```
2. Pinning subchart Postgres version to 11 is postponing upgrade problem for
the future. Users who use postgres subchart (not recommended for production)
need to pay this cost now or later anyway, for example when the oldest
supported Postgres version will be 12. So I don't see any reason to use the
oldest supported Postgres version in the helm chart by default, because default
config should provide (in my opinion) "best minimal config" rather than "oldest
compatible config".
I propose the following solution:
- keep default Postgres version for postgres subchart
- change `pgbouncer.auth_type` value to `scram-sha-256` in `values.yaml`
- provide suggestion how to migrate postgres data files from 11 to 15 using
`pg_upgrade` or `pg_dumpall` (I think I can help here).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
