yxiao1996 commented on issue #28847:
URL: https://github.com/apache/airflow/issues/28847#issuecomment-1407485475

   Took a look at the code, seems to me this should be a rather small change as 
we have the capacity to query downstreams of a task in a dag already defined in 
the dag data model 
class([code](https://github.com/apache/airflow/blob/264ace5f86e560d09444b833556074363b055f81/airflow/models/dag.py#L2153)).
 
   
   Think that we need to make changes in the following places:
   * Update UI to include new filtering method in 
template([code](https://github.com/apache/airflow/blob/main/airflow/www/templates/airflow/graph.html))
   * Update 
[callModal.js](https://github.com/apache/airflow/blob/main/airflow/www/static/js/callModal.js#L140)
 to attach handlers for new filtering options.
   * Need to extend query string of the [graph view 
function](https://github.com/apache/airflow/blob/main/airflow/www/views.py#L2910)
 to support new filtering options. Currently its assuming we are only filtering 
upstream.
   * Need to extend this 
[updateQueryStringParameter](https://github.com/apache/airflow/blob/264ace5f86e560d09444b833556074363b055f81/airflow/www/static/js/callModal.js#L25)
 function to support new filtering options.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to