tsoud commented on code in PR #29158:
URL: https://github.com/apache/airflow/pull/29158#discussion_r1092087567


##########
docs/apache-airflow/tutorial/pipeline.rst:
##########
@@ -170,7 +170,7 @@ Here we select completely unique records from the retrieved 
data, then we check
               FROM employees_temp
           ) t
           ON CONFLICT ("Serial Number") DO UPDATE
-          SET "Serial Number" = excluded."Serial Number";
+          SET "Serial Number" = t."Serial Number";

Review Comment:
   @josh-fell, thanks for the feedback! 
   
   Yep, that definitely makes much more sense. "Serial Number" is a PK so it's 
the other fields should be updated on conflict.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to