eladkal commented on code in PR #29245:
URL: https://github.com/apache/airflow/pull/29245#discussion_r1092387832
##########
airflow/providers/amazon/aws/operators/sagemaker.py:
##########
@@ -654,8 +673,8 @@ class SageMakerTrainingOperator(SageMakerBaseOperator):
the operation does not timeout.
:param check_if_job_exists: If set to true, then the operator will check
whether a training job
already exists for the name in the config.
- :param action_if_job_exists: Behaviour if the job name already exists.
Possible options are "increment"
- (default) and "fail".
+ :param action_if_job_exists: Behaviour if the job name already exists.
Possible options are "random"
+ (default), "increment" (deprecated) and "fail".
Review Comment:
My concern is specifically about pointing the (deprecated)
usually if we deprecate something, while immediate action isn't required
because we are backward compatible an action is required to be done for the
next major release (when we are making breaking change). so if we say something
is deprecated we must also say what to do, otherwise this is just inviting many
questions from users who are not sure what is expected from them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
