vandonr-amz opened a new pull request, #29274:
URL: https://github.com/apache/airflow/pull/29274

   this sensor only checks against the "wanted" status, and not other possibly 
terminal statuses.
   So if the cluster takes an unexpected branch and ends up in a semi-terminal 
state, this is completely invisible, and would only fail with an uninformative 
timeout after a long time.
   
   The "proper" fix would be to have a list of terminal states to check 
against, but I don't have enough redshift knowledge to know what's terminal in 
the long list of possible statuses:
   
   -     available
   -     available, prep-for-resize
   -     available, resize-cleanup
   -     cancelling-resize
   -     creating
   -     deleting
   -     final-snapshot
   -     hardware-failure
   -     incompatible-hsm
   -     incompatible-network
   -     incompatible-parameters
   -     incompatible-restore
   -     modifying
   -     paused
   -     rebooting
   -     renaming
   -     resizing
   -     rotating-keys
   -     storage-full
   -     updating-hsm
   
   So I'm taking this poor man's approach that'd at least allow us to get a 
sense of what happened from looking at the logs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to