sfc-gh-syeager commented on issue #24734:
URL: https://github.com/apache/airflow/issues/24734#issuecomment-1414141911

   @uranusjr 
   
   First, estimate the usecase for the most recent run, as opposed to 
ExternalTaskSensor, which looks for a run at a specific logical time. The 
usecase in question isn't worried about historical runs, meaning that the most 
recent contains all the data and references desired.
   
   Second, compare OPs request to the [current version of the 
ExternalTaskSensor](https://airflow.apache.org/docs/apache-airflow/stable/_modules/airflow/sensors/external_task.html#ExternalTaskSensor)
 class, and the usecase presented.
   
   > What time should be used to compare runs? 
   The logical time. That's how the current class does it.
   
   > Does it include manually triggered runs? If so, how should the times 
between manual and scheduled runs be compared?
   It doesn't look like the current class differentiates, so this one probably 
shouldn't either. Remember the most recent run (logical time-wise) contains all 
the references needed. If the logical time on a manual run is later than the 
logical time on any scheduled run, then the manual run is likely the one 
desired.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to