dstandish commented on code in PR #27758:
URL: https://github.com/apache/airflow/pull/27758#discussion_r1095134849
##########
chart/templates/triggerer/triggerer-deployment.yaml:
##########
@@ -44,6 +45,9 @@ metadata:
{{- toYaml .Values.triggerer.annotations | nindent 4 }}
{{- end }}
spec:
+ {{- if $persistence }}
+ serviceName: {{ .Release.Name }}-triggerer
+ {{- end }}
Review Comment:
you know... what do you think about just keeping it simple with just the
2.2.0 flag? It's not really gonna hurt anything to have the service there for
< 2.6 and it's one less bit of logic in the chart
##########
chart/templates/triggerer/triggerer-deployment.yaml:
##########
@@ -44,6 +45,9 @@ metadata:
{{- toYaml .Values.triggerer.annotations | nindent 4 }}
{{- end }}
spec:
+ {{- if $persistence }}
+ serviceName: {{ .Release.Name }}-triggerer
+ {{- end }}
Review Comment:
you know... what do you think about just keeping it simple with just the
2.2.0 flag on service? It's not really gonna hurt anything to have the service
there for < 2.6 and it's one less bit of logic in the chart
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
