Taragolis commented on code in PR #28850:
URL: https://github.com/apache/airflow/pull/28850#discussion_r1095934051


##########
airflow/providers/amazon/provider.yaml:
##########
@@ -52,6 +52,7 @@ dependencies:
   - apache-airflow>=2.3.0
   - apache-airflow-providers-common-sql>=1.3.1
   - boto3>=1.24.0
+  - aiobotocore>=2.1.1

Review Comment:
   Yeah we could catch that module not installed and raise appropriate 
exception, for example
   
   
https://github.com/apache/airflow/blob/a7e1cb2fbfc684508f4b832527ae2371f99ad37d/airflow/providers/slack/notifications/slack_notifier.py#L26-L31
   
   But also need somehow resolve additional issues:
   1. AFAIK in CI image only core providers dependencies installed (i guess we 
have some workaround). That mean we have an error in async Amazon providers 
tests because there is no `aiobotocore`
   2. If we install `aiobotocore` in CI image than we also freeze version of 
`botocore` and `boto3`. As result we could miss if our tests not work with 
modern version of `boto3` (we have some private method usage in Amazon Provider)
   
   I'm not sure how to resolve this, may be @potiuk could suggest something



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to