o-nikolas commented on code in PR #27947:
URL: https://github.com/apache/airflow/pull/27947#discussion_r1096353052
##########
airflow/providers/amazon/aws/hooks/redshift_data.py:
##########
@@ -46,3 +48,73 @@ class
RedshiftDataHook(AwsGenericHook["RedshiftDataAPIServiceClient"]):
def __init__(self, *args, **kwargs) -> None:
kwargs["client_type"] = "redshift-data"
super().__init__(*args, **kwargs)
+
+ def execute_query(
+ self,
+ database: str,
+ sql: str | list[str],
+ cluster_identifier: str | None = None,
+ db_user: str | None = None,
+ parameters: list | None = None,
+ secret_arn: str | None = None,
+ statement_name: str | None = None,
+ with_event: bool = False,
+ await_result: bool = True,
Review Comment:
This is net new code (as far as the hook is concerned) so we can rename it
here to `wait_for_completion` without any back compat issues and then leave the
name in the Operator as `await_completion` for back compat (since that was
publicly available before). The names will be inconsistent between the two
classes, but this could be seen as a step in the right direction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
