ephraimbuddy commented on code in PR #29407:
URL: https://github.com/apache/airflow/pull/29407#discussion_r1100257482


##########
airflow/models/serialized_dag.py:
##########
@@ -251,7 +251,7 @@ def remove_deleted_dags(
                     cls.fileloc_hash.notin_(alive_fileloc_hashes),
                     cls.fileloc.notin_(alive_dag_filelocs),
                     or_(
-                        cls.processor_subdir is None,
+                        cls.processor_subdir.is_(None),

Review Comment:
   While I know `is_` is the correct thing here, I think this gives us an 
opportunity to add an additional test to ensure we don't break it in the future



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to