ashb commented on code in PR #28721: URL: https://github.com/apache/airflow/pull/28721#discussion_r1107671487
########## docs/apache-airflow-providers-sqlite/connections/sqlite.rst: ########## @@ -23,14 +23,22 @@ The SQLite connection type provides connection to a SQLite database. Configuring the Connection -------------------------- -Host (required) - The host to connect to. +Host (optional) + The host to connect to. This can either be a file on disk or an in-memory database. If not set, an in-memory database is being used. -Schema (optional) - Specify the schema name to be used in the database. +Extra (optional) + Specify the extra parameters (as json dictionary) that can be used in the sqlite connection. + See `Recognized Query Parameters <https://www.sqlite.org/uri.html>`_ for all supported parameters. -Login (required) - Specify the user name to connect. +URI format example +^^^^^^^^^^^^^^^^^^ -Password (required) - Specify the password to connect. +If serializing with Airflow URI: + +.. code-block:: bash + + export AIRFLOW_CONN_SQLITE_DEFAULT='sqlite://host/?mode=ro' Review Comment: That said... Why are we changing it away from sqlite norms? Why can't we have `AIRFLOW_CONN_SQLITE_DEFAULT=sqlite:///path/to/db`? (Sorry, I've lost any and all context to this PR of late) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
