Taragolis commented on code in PR #28721:
URL: https://github.com/apache/airflow/pull/28721#discussion_r1110255085
##########
tests/providers/sqlite/hooks/test_sqlite.py:
##########
@@ -28,26 +29,32 @@
class TestSqliteHookConn:
def setup_method(self):
-
- self.connection = Connection(host="host")
-
class UnitTestSqliteHook(SqliteHook):
conn_name_attr = "test_conn_id"
self.db_hook = UnitTestSqliteHook()
- self.db_hook.get_connection = mock.Mock()
- self.db_hook.get_connection.return_value = self.connection
+ @pytest.mark.parametrize(
+ "connection, uri",
Review Comment:
Yep, it not required for `pytest`, and in general we do not use it in our
codebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
