vincbeck commented on code in PR #29581:
URL: https://github.com/apache/airflow/pull/29581#discussion_r1110293535
##########
tests/system/providers/amazon/aws/example_sagemaker_endpoint.py:
##########
@@ -88,6 +88,11 @@ def delete_endpoint(endpoint_name):
boto3.client("sagemaker").delete_endpoint(EndpointName=endpoint_name)
+@task(trigger_rule=TriggerRule.ALL_DONE)
+def archive_logs(log_group_name):
+ boto3.client("logs").put_retention_policy(logGroupName=log_group_name,
retentionInDays=1)
Review Comment:
The only issue here is `_purge_logs` do not work because of the reason
explained in the description. Even though the log group is removed, it gets
recreated because some logs are still being pushed after the system test ends.
The solution I can think of is to add a parameter `successful_test_action` (or
a better name) with the default value being `_purge_logs`. That way, for this
test, we could pass `archive_logs` as value of `successful_test_action`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
