pankajastro commented on code in PR #29642: URL: https://github.com/apache/airflow/pull/29642#discussion_r1113134255
########## tests/providers/google/cloud/sensors/test_bigquery.py: ########## @@ -37,7 +37,7 @@ TEST_IMPERSONATION_CHAIN = ["ACCOUNT_1", "ACCOUNT_2", "ACCOUNT_3"] -class TestBigqueryTableExistenceSensor(TestCase): +class TestBigqueryTableExistenceSensor: Review Comment: especially in the case of providers, I feel that class-based tests help because we have many operators/sensors in a single file so if tests are class-based it improves the readability of tests and adding/removing/updating/searching tests became a bit easy. otherwise, If I'll make small changes in the existing operator most of the time goes in figuring out do I need to add new tests or can update existing and where shall I add the new tests in a test file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
