steren commented on code in PR #28525: URL: https://github.com/apache/airflow/pull/28525#discussion_r1113612282
########## airflow/providers/google/cloud/hooks/cloud_run.py: ########## @@ -0,0 +1,245 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""This module contains a Google Cloud Run Hook.""" +from __future__ import annotations + +import json +import time +from typing import Any, Callable, Dict, List, Sequence, Union, cast + +from google.api_core.client_options import ClientOptions +from googleapiclient.discovery import build + +from airflow.providers.google.common.hooks.base_google import GoogleBaseHook +from airflow.utils.log.logging_mixin import LoggingMixin + +DEFAULT_CLOUD_RUN_REGION = "us-central1" + + +class CloudRunJobSteps: + """ + Helper class with Cloud Run job status. + Reference: https://cloud.google.com/run/docs/reference/rest/v1/namespaces.jobs#JobStatus Review Comment: Using the V2 API doesn't mean using the Cloud Run Python client library. Here, it seems like you are calling the API via HTTP directly? You could hit the /v2/ endpoint instead of the /v1/, it's much easier to use. This is optional, since you have it working on v1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
