bbovenzi commented on code in PR #29413:
URL: https://github.com/apache/airflow/pull/29413#discussion_r1116070096


##########
airflow/www/static/js/dag/details/graph/utils.ts:
##########
@@ -0,0 +1,116 @@
+/*!
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import Color from 'color';
+import type {
+  Node as ReactFlowNode,
+} from 'reactflow';
+import type { ElkExtendedEdge } from 'elkjs';
+
+import type { CustomNodeProps } from './Node';
+
+export const nodeColor = (
+  { data: { height, width, instance } }: ReactFlowNode<CustomNodeProps>,
+) => {
+  if (!height || !width) return '';
+  if (width > 200 || height > 60) {
+    return '#cccccc50';
+  }
+  if (instance?.state) {
+    return `${Color(stateColors[instance.state]).hex()}90`;
+  }
+  return '#cccccc90';
+};
+
+export const nodeStrokeColor = (
+  { data: { isSelected } }: ReactFlowNode<CustomNodeProps>,
+  colors: any,
+) => (isSelected ? colors.blue[500] : '');
+
+interface BuildEdgesProps {
+  edges?: ElkExtendedEdge[];
+  nodes: ReactFlowNode<CustomNodeProps>[];
+  taskId?: string | null;
+}
+
+export const buildEdges = ({

Review Comment:
   This is the edge data itself in a format that works for react-flow. Edge.tsx 
is the component itself. I can improve the names or add a comment to avoid 
confusion



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to