Taragolis commented on issue #29640:
URL: https://github.com/apache/airflow/issues/29640#issuecomment-1442417038

   Let's close it. Just couple of comments
   
   Even it it not a problem with airflow, but I think we need to remove part 
with check if key exists, from this method in S3Hook. The reason is simple this 
check limited by default settings under non-versioned object or last version of 
object.
   
   
https://github.com/apache/airflow/blob/e6d317608251d2725627ac2da0e60d5c5b206c1e/airflow/providers/amazon/aws/hooks/s3.py#L978-L986
   
   ---
   
   I think, but I'm not sure, `S3.Object.download_fileobj` comes from 
[s3transfer](https://github.com/boto/s3transfer) rather than botocore
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to