ferruzzi commented on code in PR #29822:
URL: https://github.com/apache/airflow/pull/29822#discussion_r1122092558
##########
airflow/providers/amazon/aws/operators/emr.py:
##########
@@ -191,8 +196,23 @@ def __init__(
aws_conn_id: str = "aws_default",
waiter_countdown: int = 25 * 60,
waiter_check_interval_seconds: int = 60,
+ # TODO: waiter_max_attempts and waiter_delay should default to None
when the other two are deprecated.
+ waiter_max_attempts: int | ArgNotSet = NOTSET,
+ waiter_delay: int | ArgNotSet = NOTSET,
**kwargs: Any,
):
+ if waiter_max_attempts is NOTSET:
+ warnings.warn(
+ "The parameter waiter_countdown has been deprecated to
standardize "
+ "naming conventions. Please use waiter_max_attempts instead.
In the "
+ "future this will default to None and defer to the waiter's
default value."
+ )
Review Comment:
I'm not sure I follow. `waiter_countdown` and
`waiter_check_interval_seconds` both already exist and we are deprecating
those, but we can't just ignore them or that would break everyone currently
using them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
