[
https://issues.apache.org/jira/browse/AIRFLOW-4963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16885574#comment-16885574
]
ASF GitHub Bot commented on AIRFLOW-4963:
-----------------------------------------
BasPH commented on pull request #5596: [AIRFLOW-4963] Avoid recreating task
context
URL: https://github.com/apache/airflow/pull/5596
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-4963
- In case you are fixing a typo in the documentation you can prepend your
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create
an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with
the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
The task context is created by taskinstance.get_template_context() and
called twice via _run_raw_task:
1. context = self.get_template_context()
2. 2nd time in render_templates(), instead of passing it as a variable
This is costly (lots of variables initialized, DB session, datetime
calculations) and can be avoided, by simply passing the context variable to
render_templates() instead of recreating.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
No functionality changed, existing tests pass.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [x] In case of new functionality, my PR adds documentation that describes
how to use it.
- All the public functions and the classes in the PR contain docstrings
that explain what it does
- If you implement backwards incompatible changes, please leave a note in
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so
we can assign it to a appropriate release
### Code Quality
- [x] Passes `flake8`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Avoid recreating task context
> -----------------------------
>
> Key: AIRFLOW-4963
> URL: https://issues.apache.org/jira/browse/AIRFLOW-4963
> Project: Apache Airflow
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.10.5
> Reporter: Bas Harenslak
> Priority: Major
> Labels: performance
>
> The task context is created by taskinstance.get_template_context() and called
> twice via _run_raw_task:
> # context = self.get_template_context()
> # 2nd time in render_template(), instead of passing it to render_template()
> This is costly (lots of variables initialized, DB session, datetime
> calculations) and can be avoided.
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
