bnguyennhon opened a new issue, #30071:
URL: https://github.com/apache/airflow/issues/30071

   ### Description
   
   The Helm Chart allows setting annotations for the pods created by the 
`CronJob` [but not the CronJob controller 
itself](https://github.com/apache/airflow/blob/helm-chart/1.8.0/chart/templates/cleanup/cleanup-cronjob.yaml).
   
   The values file should offer an option to provide custom annotations for the 
`CronJob` controller, similarly to how the DB migrations job exposes 
`.Values.migrateDatabaseJob.jobAnnotations` 
   
   In the same fashion, other `Deployment` templates expose custom annotations, 
but [statsd deployment 
doesn't](https://github.com/apache/airflow/blob/helm-chart/1.8.0/chart/templates/statsd/statsd-deployment.yaml).
   
   ### Use case/motivation
   
   Other tools e.g. ArgoCD may require the use of annotations, for example:
   * [ArgoCD Sync 
Options](https://argo-cd.readthedocs.io/en/stable/user-guide/sync-options)
   * [ArgoCD Sync Phases and 
Waves](https://argo-cd.readthedocs.io/en/stable/user-guide/sync-waves/)
   
   Example use case:
   _Set the cleanup CronJob to be synced after the webserver and scheduler 
deployments have been synced with ArgoCD_
   
   ### Related issues
   
   https://github.com/apache/airflow/issues/25446 originally mentioned the 
issue regarding the StatsD deployment, but the accepted fix was 
https://github.com/apache/airflow/pull/25732 which allows setting annotations 
for the pod template, not the `Deployment` itself
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to