potiuk commented on PR #28850:
URL: https://github.com/apache/airflow/pull/28850#issuecomment-1471982103

   Yep. Looks better:
   
   <img width="739" alt="Screenshot 2023-03-16 at 14 33 45" 
src="https://user-images.githubusercontent.com/595491/225633395-0460e2eb-125a-42d8-96df-f99938ac8e9e.png";>
   
   Also as expected botocore/boto were downgraded in the process automatically 
in constraints:
   
   
https://github.com/apache/airflow/actions/runs/4436088571/jobs/7784082644?pr=30127
   
   <img width="878" alt="Screenshot 2023-03-16 at 14 35 16" 
src="https://user-images.githubusercontent.com/595491/225633758-826b0a99-a001-4953-a47a-e99a1ea9271b.png";>
   
   As unfortunate as it is, seems that currently we do not have any AWS 
providers that rely on features unavailable in this version and all tests pass, 
so having it in constraints as "reference" one is not a big issue.
   
   The reall effect of doing it this way is simply slower pace of upgrading of 
the botocore/boto in our tests. Which is not as bad actually. 
   
   I thought about it and we could also make another change after 
https://github.com/apache/airflow/pull/30127 is merged (@Taragolis @kaxil 
@o-nikolas ): We could add a single extra job (a little more complex than the 
one initially added by @pankajastro ) where we could start the image,  remove 
aiobotocore, upgrade botocore and boto to latest compatible versions and run 
all amazon provider unit tests there (because of lack of aiobotocore, the tests 
for deferred operators would be skipped automatically)
   
   This should be rather simiple to set-up and it would give us much more 
confidence that the operators we have not only work with the 
aiobotocore-compatible version but also with the "latest" version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to