pingzh commented on code in PR #30104: URL: https://github.com/apache/airflow/pull/30104#discussion_r1139059088
########## airflow/utils/file.py: ########## @@ -335,7 +335,23 @@ def find_dag_file_paths(directory: str | pathlib.Path, safe_mode: bool) -> list[ COMMENT_PATTERN = re.compile(r"\s*#.*") -def might_contain_dag(file_path: str, safe_mode: bool, zip_file: zipfile.ZipFile | None = None): +def might_contain_dag(file_path: str, safe_mode: bool, zip_file: zipfile.ZipFile | None = None) -> bool: Review Comment: that is a good idea. in this way, we don't need to expose `safe_mode` to the callable as part of the interface -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
