potiuk commented on issue #30427: URL: https://github.com/apache/airflow/issues/30427#issuecomment-1494137695
> > #30216 should not be included in a release yet. Is there a way this can be avoided @eladkal > > Good catch, but I think this is a wrong question. > > Part of the change is in `cncf.kubernetes` @ephraimbuddy -> this is what''s being released, so if it is not compatible with currently released airflow, it should be fixed. Generally the expectation is that if there is any change in a provider that requires some changes to airflow core, one of the two things happen: > > a) it is made in a backwards-compatble way that will be well handled in the older airflow version (by fallback, etc.) b) it limits min-airflow version to be the future airflow version in `provider.yaml` > > In this case, I think a) case is the right approach, so my question is (and mostly to you @ephraimbuddy :) > > Is it backwards compatible with airlfow 2.3+? > > if yes-> all is cool and we can release `cncnf.kubernetes` as is. If not, we should remove `cncf.kubernetes` from the release and fix it so that it is backwards compatible (and prepare rc2). BTW. Looking at the code, it seems it is backwards-compatible, but I would love if you can confirm it @ephraimbuddy. And if it is, there is absolutely no problem in including that change in this release and it is how it should be. Imagine someone installing 2.6.0 tomorrow with setup teardown. If there is no released version of cncf.kubernetes that is compatible with it released, then we would be in a big trouble - this actueally means that we HAVE TO release `cncf.kubernetes` with this change before Airflow 2.6 is released. There is no other way. If we don't release it before, it will not work properly when 2.6.0 is released. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
