potiuk commented on PR #30367:
URL: https://github.com/apache/airflow/pull/30367#issuecomment-1503247623

   > > the orignal place where it was added
   > 
   > Do you mean the place where `__version__` is defined, or where it is 
accessed via subprocess?
   
   I'd opt for both. Just to improve the reeadability - why the original one 
was added (and remove the scary "don't use it if you do not know what you are 
doing" along the way) and why we think it's good to add _IS_LIBRARY. That's 
about it. Just to provide the context so that next person looking it will known 
without having to trace it back to the original commit and guessing the reasons.
   
   I am just thinking of the future self and future "other" maintainer or user 
who would stumble upon this one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to