ferruzzi commented on PR #30541:
URL: https://github.com/apache/airflow/pull/30541#issuecomment-1507302646

   > Need to come up with convention for prefix Amazon / AWS / Amazon AWS ?
   
   As I mentioned in one of the comments above, I think we should call it what 
it is.  Some services are officially AWS {Foo} (like AWS Batch) while others 
are officially Amazon {Bar} (like Amazon SageMaker).   The [AWS Docs 
page](https://docs.aws.amazon.com) is IMHO the official Source of Truth.  So we 
should match those names.   For example, you've changes Athena to AWS Athena in 
[some 
places](https://github.com/apache/airflow/pull/30541/files#diff-d10e8ebe7b61e88c5dd452f84ddda78d839fa57309adeb6a9e3aceed98c5ab30R19)
 but not in 
[others](https://github.com/apache/airflow/pull/30541/files#diff-d10e8ebe7b61e88c5dd452f84ddda78d839fa57309adeb6a9e3aceed98c5ab30R22),
 those should be changed back to Amazon Athena per [their official doc 
page](https://docs.aws.amazon.com/athena/)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to