uranusjr commented on code in PR #30485:
URL: https://github.com/apache/airflow/pull/30485#discussion_r1166043127
##########
airflow/cli/commands/celery_command.py:
##########
@@ -96,6 +100,27 @@ def _serve_logs(skip_serve_logs: bool = False):
sub_proc.terminate()
+@after_setup_logger.connect()
+def logger_setup_handler(logger, **kwargs):
+ # Setup levels at which logs go to stderr and stdout if required
+ if conf.get("logging", "celery_logging_split", fallback=None):
+ celery_formatter = logging.Formatter(DEFAULT_TASK_LOG_FMT)
+
+ class NoErrorOrAboveFilter(logging.Filter):
+ def filter(self, record):
+ return record.levelno <= logging.WARNING
+
+ below_error_handler = logging.StreamHandler(sys.stdout)
+ below_error_handler.addFilter(NoErrorOrAboveFilter())
Review Comment:
I flipped the wording to a positive tone (I think it avoids some mental
overhead), and also switch to `< logging.ERROR` instead. Using `<=
logging.WARNING` is problematic; it is possible to emit a log with an
in-between level, e.g. `log(35, "...")` that would be missed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
