uranusjr commented on code in PR #30380:
URL: https://github.com/apache/airflow/pull/30380#discussion_r1166060230
##########
airflow/cli/commands/task_command.py:
##########
@@ -450,13 +448,12 @@ def task_failed_deps(args):
dep_context = DepContext(deps=SCHEDULER_QUEUED_DEPS)
failed_deps = list(ti.get_failed_dep_statuses(dep_context=dep_context))
- # TODO, Do we want to print or log this
if failed_deps:
- print("Task instance dependencies not met:")
Review Comment:
If we use logging here the output would be affected by custom logging
config, but in these CLI parts we _should_ log to stdout (or stderr) regardless
of how the user configures Airflow logging. Using `print` is correct for this
purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
