hussein-awala commented on code in PR #29809:
URL: https://github.com/apache/airflow/pull/29809#discussion_r1166074222
##########
airflow/kubernetes/kube_client.py:
##########
@@ -125,5 +138,5 @@ def get_kube_client(
if ssl_ca_cert:
configuration.ssl_ca_cert = ssl_ca_cert
- api_client = client.ApiClient(configuration=configuration)
+ api_client = client.ApiClient(configuration)
Review Comment:
Using keyword arguments is always recommended
```suggestion
api_client = client.ApiClient(configuration=configuration)
```
##########
airflow/config_templates/config.yml:
##########
@@ -2570,6 +2570,13 @@ kubernetes_executor:
previous_name: kubernetes
version: 2.5.0
options:
+ api_client_retry_configuration:
+ description: |
+ Settings to configure the Retry hook, consumed by Kubernetes client.
+ version_added: 2.6.0
Review Comment:
```suggestion
Kwargs to override the default urllib3 Retry used in the kubernetes
API client
version_added: 2.6.1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
