pierrejeambrun opened a new pull request, #30633:
URL: https://github.com/apache/airflow/pull/30633

   Follow up of https://github.com/apache/airflow/pull/30373, you can only look 
at the last commit that allows to display the affected task instances in a 
table for more visibility when performing an action in the grid view.
   
   I wish we could serialize the data using a standardized schema for both 
`api_connexion` and `views`. In such case being able to use a shared 
`TaskInstanceSchema` would be helpful for consistency. I don't think we need 
many representations of a serialized TaskInstance (or any other object) for the 
webserver.
   
   Right now `api_connexion` and `views` well separated, so coupling the  two 
by importing this schema into the view feels wrong but maybe having some shared 
schema in a parent folder could prove useful. Also at the moment the current 
`TaskInstanceSchema` works on a tuple with SLA miss, and cannot dump bare 
'TaskInstance' objects, then it becomes a little bit hacky to manually fill 
empty value for those just for serialization.
   
   ## Before
   
![image](https://user-images.githubusercontent.com/14861206/231899909-e296807c-8ba7-4622-bda5-1f2f77daa7a7.png)
   
   
   ## After
   
![image](https://user-images.githubusercontent.com/14861206/231899817-ea90c2ae-14b8-49e1-80d0-143cb72a616e.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to