vandonr-amz commented on code in PR #30705:
URL: https://github.com/apache/airflow/pull/30705#discussion_r1170591283
##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -606,7 +606,43 @@ def parallel_test_types(self) -> str:
)
test_types_to_remove.add(test_type)
current_test_types = current_test_types - test_types_to_remove
- return " ".join(sorted(current_test_types))
+ for test_type in tuple(current_test_types):
+ if test_type == "Providers":
+ current_test_types.remove(test_type)
+ current_test_types.update(
+ ("Providers[amazon]", "Providers[google]",
"Providers[-amazon,google]")
+ )
+ elif test_type.startswith("Providers[") and "amazon" in test_type
or "google" in test_type:
+ current_test_types.remove(test_type)
+ if "amazon" in test_type:
+ current_test_types.add("Providers[amazon]")
+ if "google" in test_type:
+ current_test_types.add("Providers[google]")
Review Comment:
Oh yeah ok I was not aware of those shortcomings. I'm just a bit weary of
introducing some `if amazon:` in the code, but I understand how the situation
here is... special ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
